The modified code handles a cache request in the following manner: If the cached version of a page is not available for a given timestamp, the code searches for the first timestamp greater than the given timestamp in which, the cached version of the page exists. If such a timestamp is found, the cached version of the page is displayed. Otherwise, a "no cache" results.

Your 2012-10-23 23:52 patch has changes to config.php that are specific to your installation. Please take those changes out and make a new patch. When developing you can use local_config.php so you don't need to edit the WORK_DIRECTORY variable in config.php

Best, Chris

Thanks Akshat

yioopdec142012.patch applied with tweak as f04103b

The new patch tries to display localized dates. Works well as long as there are no special characters. I am working on how to deal with special characters.

Hey Akshat,

Your Dec 15 patch does not apply. Please do a git pull before creating a patch, it has your earlier patch in it. I am following the convention that after (but not before) things like commas there should be a space. i.e.,

list($a, $b) = $tmp; not list($a,$b) = $tmp; or list($a , $b) = $tmp;

for($i = 0; $i < 10; $i++) { } not for($i=0;$i<10;$i++) { } or for($i=0 ; $i<10 ; $i++) { }

The function formatByLocale should be moved into lib/locale_functions.php . Remember to refactor your code. You're almost done for the semester, and what you have done so far is cool... so keep at it.

Best, Chris

Hey Akshat,

I am seeing links like: December #d 09:34 Presumable #d should be a day.

historyUI and viewLinksByYearMonth need phpdocs

It still listing history elements for crawls that don't have a cache of an item. Can you make a patch to fix these things? Do a git pull first as I did a couple small tweaks after applying your last patch of Dec17.

Best, Chris

Thanks for your Dec 19th patch. I made some further tweaks and I feel this issue was pretty much resolved by d83e4c3e.

Fixed by d83e4c3e

Attachments:

cache_control_modified.patch

modified_cache_request_and_control.patch

modified_cache_control.patch

yioop_dec42012.patch

yioopdec142012.patch

yioop_dec152012.patch

yioop_dec172012.patch

yioop_dec192012.patch