Since I was a child, I have always wanted a Dutch locale on the Yioop search engine. It would be nice if the Yioop search engine had one.

Steps to reproduce: Click Settings and Nederlands is not in the list of languages to choose from.

Hey Charles,

I just noticed you made an issue. When you create an issue, please be sure to add me (either administrator or cpollett) to the issue. That way I'll be sent an email about it. You attached a zip file above rather than a patch. I took a quick look at it and it seemed okay except for the following:

(1) I've switched to avoiding having blank lines in my source code files, so could you remove any blank lines. Also, there were a couple of lines which had spaces at the end of them.

(2) Yioop uses 1 true brace rather than vertically aligned braces.

(3) There seems to be a stray dollar sign at the end of tokenizer.php

To make a patch as opposed to the zip file you will probably need to move these files from your work directory back to your install directory locale folder.

Best, Chris

1. I have removed the blank lines and trialing spaces from the tokenizer.php and nl_tokenizer_test.php files.

2. I moved the opening brace up one line so there is on 1 true brace throughout the tokenizer.php and nl_tokenizer_test.php

files. 3. I removed the stray $ from the end of the tokenizer.php file. I am not sure where that came from because it is not in

my original working file.

4. I had trouble making the my.patch file. I was not sure what was going on so I attached a zip to the case so you could

review the code if you had time. I was hoping on Wednesday we could walk through it.

Hey Charles,

Okay, we can go through the patch making process tomorrow. When you create a new patch etc, please leave the old one there for a historical record. I looked at the code above. It seemed the unit test file was using one truce brace, but tokenizer.php wasn't. Your code relies on the existence of the nl locale tag in the database. I will show you tomorrow how to create upgrade database and upgrade locale functions that could migrate people from the pre-Dutch Yioop to one with Dutch. I will do it though for this first patch because I think this issue was big enough for a first issue.

Best, Chris

Thanks. I did not update the zip file with the changes. I was expecting to upload it with the patch we create tomorrow.

I have added my.patch2 that contains the config.php and created.php updates.

Hey Charles, thanks for your patch. Your changes are live. If you do a git diff between 86fbda34 and b1444494 you can see how I added the db code to upgrade_functions.php to handle the upgrade.

Best, Chris

Attachments:

DutchStemmer.zip

my.patch

my.patch2