Adding new module to be used to stem Portuguese words
Steps to reproduce:
NA
Additional information:
NA
administrator2015-04-02 22:25
PLease upload your patch when ready
administrator2015-04-03 07:26
Hi Nirav,
Thanks for your patch. Please revise it addressing the issues below:
(1) Your patch has a lot of tabs rather than 4 white spaces in it,
and also stray white space at the end of lines
(2) You have a few lines over 80 chracters, for example, around line 162 in the
patch.
(3) Several of your variable names are not following Yioop coding conventions
that variables should be all lower case with words separated by underscores.
For example, variables like $SpecialSuffix should be $special_suffix.
Best,
Chris
niravkumar2015-04-09 21:22
Hi Chris,
Thanks for the update.
I have attached updated patch.
Please have look and let me know if further change required.
Adding new module to be used to stem Portuguese words
Steps to reproduce: NA
Additional information: NA
PLease upload your patch when ready
Hi Nirav,
Thanks for your patch. Please revise it addressing the issues below: (1) Your patch has a lot of tabs rather than 4 white spaces in it, and also stray white space at the end of lines (2) You have a few lines over 80 chracters, for example, around line 162 in the patch. (3) Several of your variable names are not following Yioop coding conventions that variables should be all lower case with words separated by underscores. For example, variables like $SpecialSuffix should be $special_suffix.
Best, Chris
Hi Chris,
Thanks for the update. I have attached updated patch.
Please have look and let me know if further change required.
Thanks, Nirav
Hey Nirav,
Thanks for your patch. It is now live.
Best, Chris
Fixed by 69dfc15d1
Attachments:
my.patch
my_updated.patch
my_updated_v1.patch