After I submitted issue 0000172 I began to have dreams about a universal CMS detector. In issue 0000172 the CMS detectors were individual files that could detect only one CMS. Now it is database driven with one detector that can detect many different CMSs keying on unique items in the HTML header.
I have uploaded the patches in two files. One that has all of the database changes and another that has the code changes for the UI.
Steps to reproduce:
N/A
administrator2016-05-11 14:45
Hey Charles,
Thanks for the patch I have applied it to my local copy. There was a minor issue where a forward slash should have been a . at line 1271 that I fixed. You don't need to re-upload a new patch. I am now testing the second patch. Will close
when done.
Best,
Chris
charles.bocage2016-05-11 14:48
Which file are you referring to? I would like to see why it could have been wrong.
administrator2016-05-11 14:54
UpgradeFunctions.php
charles.bocage2016-05-11 15:00
I see. Sorry about that.
administrator2016-05-11 15:01
Hey Charles,
I've pushed code with your db patch live. I couldn't get the CMS patch to apply because of errors in PublicHelpPages.php. Can you try a fresh clone and see if you can modify your second patch so it will apply?
Best,
Chris
charles.bocage2016-05-11 15:04
I should be able to do that tonight.
charles.bocage2016-05-12 15:42
I have done a fresh get and republished the help file. I uploaded the patch as myDatabase2.patch. I hope it works this time.
charles.bocage2016-05-12 15:43
My bad. The file is myCMSActivity2.patch.
administrator2016-05-19 11:06
Both patches applied before commit f33a21382. Thanks for your hard work!
After I submitted issue 0000172 I began to have dreams about a universal CMS detector. In issue 0000172 the CMS detectors were individual files that could detect only one CMS. Now it is database driven with one detector that can detect many different CMSs keying on unique items in the HTML header.
I have uploaded the patches in two files. One that has all of the database changes and another that has the code changes for the UI.
Steps to reproduce: N/A
Hey Charles,
Thanks for the patch I have applied it to my local copy. There was a minor issue where a forward slash should have been a . at line 1271 that I fixed. You don't need to re-upload a new patch. I am now testing the second patch. Will close when done.
Best, Chris
Which file are you referring to? I would like to see why it could have been wrong.
UpgradeFunctions.php
I see. Sorry about that.
Hey Charles,
I've pushed code with your db patch live. I couldn't get the CMS patch to apply because of errors in PublicHelpPages.php. Can you try a fresh clone and see if you can modify your second patch so it will apply?
Best, Chris
I should be able to do that tonight.
I have done a fresh get and republished the help file. I uploaded the patch as myDatabase2.patch. I hope it works this time.
My bad. The file is myCMSActivity2.patch.
Both patches applied before commit f33a21382. Thanks for your hard work!
Attachments:
myDatabase.patch
myCMSActivity.patch
myCMSActivity2.patch