« Back Issue #274
  • 2016-11-17 13:01 Reported by harikanukala
  • 2016-11-25 13:22 Marked fixed
Status: Marked fixed
Priority: Medium

Chat bot configuration in Yioop

harikanukala 2016-11-17 13:01

Chat bot configuration in Yioop

administrator 2016-11-18 23:19

Hey Harika,

Thanks for the patch! Make sure to add me to the monitor list of a patch when you upload it. That way I'll get an email.

Looking at your patch, I see a bunch of stuff related to your IDE in it. (.idea subfolder). Otherwise, the code part looks good. Can you upload a new patch with the IDE stuff removed?

Best, Chris

harikanukala 2016-11-21 19:03

Hello Professor, I have updated the patch as requested. Please check the attached copy of patch.

Thanks, Harika.

harikanukala 2016-11-22 16:24

Hello Professor, I have updated the patch as requested. Please check the attached copy of patch. Let me know if the patch need more changes.

Thanks, Harika.

administrator 2016-11-22 18:44

Hi Harika,

I tried to apply your patch and it wouldn't apply. Can you make a new patch and test it against a current git clone to make sure it works.

Best, Chris

administrator 2016-11-25 13:21

Hi Harika,

I edited your patch so that it could be applied. Please look at the changes I've made. In your upgrade code, you didn't have add bot role.

Best Chris

administrator 2016-11-25 13:22

Fixed by 093122a. Thanks Harika!

harikanukala 2016-11-25 13:22
X