When the user is editing a presentation-type wiki page, Add a slide button should be present along with other wiki buttons to enable the user to add a sample slide.

This button should not show up on any other wiki edit toolbars.

Added the patch for teh new button fix. Also added icon image - wikibtn-slide.png, which is used in the toolbar.

Hi Professor,

Just wanted to check If you got a chance to review this.

Eswara

Hey Eswara,

It looks good. $dataButtons should be $data_buttons, use e() rather than echo. Send a new patch and I'll push it live.

Chris

Thanks Professor, new patch attached.

Hey Eswara, I just noticed your javascript code isn't localized (you fix the default slide language to English). It also introduced whitespace errors when applied. You also should not force add in wiki element whitespace at the start of the textarea like your code does. You had one line over 80 columns. Please test it carefully after revising.

Best, Chris

Hi Professor,

Sorry about that. I have revised my code to fix all the issues mentioned. Also I spent some time testing this to make sure there are no other issues. Please let me know If the latest patch looks good or needs more changes.

The latest changes are in the latest commit is : e18fd2355573b5331a34045a16175083f2141a86 in wikibuttonsv2.patch

[edit] updated the right patch, after adding line wrap. Also updating the commit id.

Also I ammended the commit to include new wrap changes, SO I have deleted the old patches which were duplicates of wikibuttonsv2.patch

Thanks Eswara

Fixed by c47cd8eb

Good Job!

Attachments:

0001-Added-New-wiki-button-for-Add-slide.patch

wikibuttons.patch

wikibuttonsv2.patch