In this issue, I will add fixes that were missed out and not applied from the last patch. I will also add fixes to the Groups info HTML table and other minor fixes.
epinapala2014-12-19 12:05
Hi Professor,
Here is the first patch with some changes to help. Just to keep up with the commits, I will add more patches with more changes.
please see help_refactoring_1.patch
short summary:
- Add "Edit" functionality to new articles not existing but
added to help buttons. - More changes to access control. - refactor createdb
for easy insertions of doc urls.
Thanks
Eswara
administrator2014-12-19 13:47
I've pushed your changes. Please not the correction to api_controller.php
epinapala2014-12-19 13:56
Oops, Sorry I missed the check for HEAD > title. Thanks for the correction.
Also I was a not able to reproduce the table width problem when help article is open. I tried creating a group with longer title but still do not see the issue on http://yioop.com/?c=admin&YIOOP_TOKEN=xTSnQq5LeSg|1419025913&a=manageGroups
However, I will go ahead and make the changes below for manageGroups ,
- Remove the columns Register, Access , Voting. ( which I think will fix the table width when help is open.)
- add a [users] link beside [wiki], clicking on which would open up the url - &a=manageGroups&arg=editgroup&group_id={group_id}
and inturn triggers - javascript:toggleUserCollection('visible-users') to show the users.
please confirm.
Thanks
Eswara
administrator2014-12-19 15:19
Seems fine. Hopefully you mean add a [users] link?
epinapala2014-12-19 15:45
Sorry about the typo, I mean add :)
administrator2015-09-23 14:10
I think the subject matter dealt with by this issue was completed by Version 2.
In this issue, I will add fixes that were missed out and not applied from the last patch. I will also add fixes to the Groups info HTML table and other minor fixes.
Hi Professor,
Here is the first patch with some changes to help. Just to keep up with the commits, I will add more patches with more changes.
please see help_refactoring_1.patch
short summary: - Add "Edit" functionality to new articles not existing but
Thanks Eswara
I've pushed your changes. Please not the correction to api_controller.php
Oops, Sorry I missed the check for HEAD > title. Thanks for the correction.
Also I was a not able to reproduce the table width problem when help article is open. I tried creating a group with longer title but still do not see the issue on http://yioop.com/?c=admin&YIOOP_TOKEN=xTSnQq5LeSg|1419025913&a=manageGroups
However, I will go ahead and make the changes below for manageGroups ,
- Remove the columns Register, Access , Voting. ( which I think will fix the table width when help is open.) - add a [users] link beside [wiki], clicking on which would open up the url - &a=manageGroups&arg=editgroup&group_id={group_id} and inturn triggers - javascript:toggleUserCollection('visible-users') to show the users.
please confirm.
Thanks Eswara
Seems fine. Hopefully you mean add a [users] link?
Sorry about the typo, I mean add :)
I think the subject matter dealt with by this issue was completed by Version 2.
Attachments:
help_refactoring_1.patch