Fixing a small bug related to adding users to a group in Yioop
yashi2016-04-03 13:37
While adding large number of users to a group, if a user is activated/deleted/banned/reinstated in the group, then it brings the admin back to the beginning of the list of users in the group. For instance, there are 21 users in the group and the admin adds user 16 to the group, then upon Activating user 16, the admin is brought back to the beginning of the list of users in that group. The issue here is that the admin has to traverse the list sequentially to reach to user 16. This can be problematic if there are very large number of users, say 50 or 100.
Steps to reproduce:
The following steps would assist in reproducing the issue:
1. Access Yioop homepage as an admin
2. Go to Social->Manage Groups->Click the group in which you got multiple user requests ( User requests can also be created by making multiple user accounts and requesting access to the particular group, say "TestGroup.")
3. Click Edit under Actions and then click on the link which displays the number of user requests under Members.
4. Click on the link. It displays the number of users, requesting access to the group.
5. Scroll next pages of the list using ">>". Choose one of the users and activate the user there by clicking Activate.
6. The admin would be brought back to the beginning of the list.
Additional information:
N.A.
yashi2016-04-03 15:34
Hello Professor,
Hope you had a good spring break. The patch file has been zipped and added for your approval.
Regards,
Yashi
administrator2016-04-03 17:00
Hey Yashi,
Post your patch as a patch not a zip file, so I can look at it without downloading it.
Best,
Chris
yashi2016-04-03 18:04
Hello Professor,
I am unable to upload the file without zipping it. This is the message that I get, "File upload failed. This is likely because the file size was larger than is currently allowed by this PHP installation."
Patch size: 9,991 KB. Changes have been made in just two php files to fix this error.
May be I am doing something wrong.Not sure. Please guide.
Regards,
Yashi
administrator2016-04-03 18:12
Hi Yashi,
My guess is you haven't changed that much, so either make a fresh clone and add your changes to it and make a new patch, or use something like:
http://gitready.com/intermediate/2009/03/04/pick-out-individual-commits.html
Best,
Chris
yashi2016-04-03 20:54
Hello Professor,
I cloned the fresh source for Yioop (to make a new patch) from the Git URL - "https://seekquarry.com/git/yioop.git". I am unable to run Yioop by executing the following: localhost/yioop in my browser (XAMPP Server running).
I will discuss this further with you tomorrow, 04/04/2016 during your office hours.
Regards,
Yashi
administrator2016-04-07 09:02
Hey Yashi,
When you make a new patch remember to leave the old patch there so we preserve a history of what happened for this issue.
Best,
Chris
yashi2016-04-07 09:13
Hello Professor,
Thank you for letting me know. I will add a new patch and keep the old one as it is for records.
Regards,
Yashi
yashi2016-04-12 15:55
Hello Professor,
I have uploaded the new patch. Please approve.
Regards,
Yashi
administrator2016-04-12 22:04
Hey Yashi,
Thanks for the second patch! It worked. Please email me the developer agreement.
While adding large number of users to a group, if a user is activated/deleted/banned/reinstated in the group, then it brings the admin back to the beginning of the list of users in the group. For instance, there are 21 users in the group and the admin adds user 16 to the group, then upon Activating user 16, the admin is brought back to the beginning of the list of users in that group. The issue here is that the admin has to traverse the list sequentially to reach to user 16. This can be problematic if there are very large number of users, say 50 or 100.
Steps to reproduce: The following steps would assist in reproducing the issue: 1. Access Yioop homepage as an admin 2. Go to Social->Manage Groups->Click the group in which you got multiple user requests ( User requests can also be created by making multiple user accounts and requesting access to the particular group, say "TestGroup.") 3. Click Edit under Actions and then click on the link which displays the number of user requests under Members. 4. Click on the link. It displays the number of users, requesting access to the group. 5. Scroll next pages of the list using ">>". Choose one of the users and activate the user there by clicking Activate. 6. The admin would be brought back to the beginning of the list.
Additional information: N.A.
Hello Professor, Hope you had a good spring break. The patch file has been zipped and added for your approval.
Regards, Yashi
Hey Yashi,
Post your patch as a patch not a zip file, so I can look at it without downloading it.
Best, Chris
Hello Professor, I am unable to upload the file without zipping it. This is the message that I get, "File upload failed. This is likely because the file size was larger than is currently allowed by this PHP installation." Patch size: 9,991 KB. Changes have been made in just two php files to fix this error. May be I am doing something wrong.Not sure. Please guide.
Regards, Yashi
Hi Yashi,
My guess is you haven't changed that much, so either make a fresh clone and add your changes to it and make a new patch, or use something like: http://gitready.com/intermediate/2009/03/04/pick-out-individual-commits.html
Best, Chris
Hello Professor, I cloned the fresh source for Yioop (to make a new patch) from the Git URL - "https://seekquarry.com/git/yioop.git". I am unable to run Yioop by executing the following: localhost/yioop in my browser (XAMPP Server running). I will discuss this further with you tomorrow, 04/04/2016 during your office hours.
Regards, Yashi
Hey Yashi,
When you make a new patch remember to leave the old patch there so we preserve a history of what happened for this issue.
Best, Chris
Hello Professor, Thank you for letting me know. I will add a new patch and keep the old one as it is for records.
Regards, Yashi
Hello Professor, I have uploaded the new patch. Please approve.
Regards, Yashi
Hey Yashi,
Thanks for the second patch! It worked. Please email me the developer agreement.
Best, Chris
Fixed with f0eaf2b098
Attachments:
yashikamboj.zip
YashiKamboj.patch