Recommending threads and groups (tf-idf) along with trending threads (baseline predictors) to users based on their log history.
sarika3122017-05-17 19:46
PFA the final patch for the recommendation system
sarika3122017-05-17 20:33
This is the final Patch which needs to be pushed
I tweaked the time interval for the job in this.
administrator2017-05-17 23:11
Hey Sarika,
Thanks for the patch! It's been push to the git repository now. I noticed two things that should be fixed:
(1) A lot of the documentation added isn't useful. For example, the documentation on trendingJob just says Trending Job. A docblock on a method should say something meaningful about what it does, not just repeat the method name. It should also have @param and if applicable @return. The type that is given for an @param should be a PHP type, all of which are lower case. All methods should be documented.
(2) I noticed a conflict between yours and Pragya's stuff. Namely, if a thread is for an encrypted group, but ends up trending, then when it is displayed in the trending area, it isn't decrypted, so appears as garbage. It is probably better for encrypted groups to be excluded from the trending calculation. I'm not sure who between you two is better able to address this issue. I tell her about it as well tomorrow.
Best,
Chris
administrator2017-11-22 14:14
Thanks for your work Sarika. This patch has been applied for a while, just closing issue now. f8e66cbeb
Recommending threads and groups (tf-idf) along with trending threads (baseline predictors) to users based on their log history.
PFA the final patch for the recommendation system
This is the final Patch which needs to be pushed I tweaked the time interval for the job in this.
Hey Sarika,
Thanks for the patch! It's been push to the git repository now. I noticed two things that should be fixed: (1) A lot of the documentation added isn't useful. For example, the documentation on trendingJob just says Trending Job. A docblock on a method should say something meaningful about what it does, not just repeat the method name. It should also have @param and if applicable @return. The type that is given for an @param should be a PHP type, all of which are lower case. All methods should be documented. (2) I noticed a conflict between yours and Pragya's stuff. Namely, if a thread is for an encrypted group, but ends up trending, then when it is displayed in the trending area, it isn't decrypted, so appears as garbage. It is probably better for encrypted groups to be excluded from the trending calculation. I'm not sure who between you two is better able to address this issue. I tell her about it as well tomorrow.
Best, Chris
Thanks for your work Sarika. This patch has been applied for a while, just closing issue now. f8e66cbeb
Best, Chris
Attachments:
recommendation.patch
RecommendationSystemFinal.patch
RecommendationJob.patch