The unit tests for IndexShard don't seem to correlate with the latest version of the class itself. One notable example is that the argument passed for whether we're adding a document or a link to a document has been changed. While this change hasn't broken any of the pre-existing tests, writing new ones that check for this result in failure.
administrator2019-03-12 12:50
Hi Tim,
Thanks for the patch. Remove lines with whitespace and change tabs to 4 spaces. Resubmit.
The unit tests for IndexShard don't seem to correlate with the latest version of the class itself. One notable example is that the argument passed for whether we're adding a document or a link to a document has been changed. While this change hasn't broken any of the pre-existing tests, writing new ones that check for this result in failure.
Hi Tim,
Thanks for the patch. Remove lines with whitespace and change tabs to 4 spaces. Resubmit.
Thanks,
Chris
Attachments:
my-2.patch
my-3.patch
my.patch