pull BATCH_SQL_INSERT_NUM out of RecommendationJob as a global constant, =achris
pull BATCH_SQL_INSERT_NUM out of RecommendationJob as a global constant, =achris
diff --git a/src/configs/Config.php b/src/configs/Config.php
index 19280d973..662b6ae93 100755
--- a/src/configs/Config.php
+++ b/src/configs/Config.php
@@ -1264,8 +1264,6 @@ nsdefine('LONG_NAME_LEN', 64);
nsdefine('SHORT_TITLE_LEN', 128);
/** Length for names of things like titles of blog entries, etc */
nsdefine('TITLE_LEN', 512);
-/** Number of components in a term or item embedding */
-nsdefine('EMBEDDING_VECTOR_SIZE', 200);
/** Length of a feed item or post, etc */
nsdefine('MAX_GROUP_POST_LEN', 8192);
/** Length for for the contents of a wiki_page */
@@ -1284,6 +1282,11 @@ nsdefine('NUM_FIELD_LEN', 4);
nsdefine('WRITING_MODE_LEN', 5);
/** Max user session size */
nsdefine('MAX_USER_SESSION_SIZE', 16384);
+/** Number of components in a term or item embedding */
+nsdefine('EMBEDDING_VECTOR_SIZE', 200);
+/** Max number of inserts to do in a single insert statement for
+ */
+nsconddefine('BATCH_SQL_INSERT_NUM', 500);
/*
* Wiki forms related
*/
diff --git a/src/library/media_jobs/RecommendationJob.php b/src/library/media_jobs/RecommendationJob.php
index 82ceac248..0d74853cd 100644
--- a/src/library/media_jobs/RecommendationJob.php
+++ b/src/library/media_jobs/RecommendationJob.php
@@ -69,11 +69,6 @@ class RecommendationJob extends MediaJob
* LRUCache for term embeddings
*/
public $lru_cache;
- /**
- * Number of inserts to try to group into a single insert statement
- * before execution
- */
- const BATCH_SQL_INSERT_NUM = 500;
/**
* Maximum number of group items used in making recommendations
*/
@@ -448,7 +443,7 @@ class RecommendationJob extends MediaJob
$comma = ",";
$insert_count++;
$total_insert++;
- if ($insert_count == self::BATCH_SQL_INSERT_NUM) {
+ if ($insert_count == C\BATCH_SQL_INSERT_NUM) {
$delete_sql .= ")";
$db->execute($delete_sql, [C\THREAD_RECOMMENDATION]);
$insert_sql = $db->insertIgnore($insert_sql);
@@ -590,7 +585,7 @@ class RecommendationJob extends MediaJob
$comma = ",";
$insert_count++;
$total_insert++;
- if ($insert_count == self::BATCH_SQL_INSERT_NUM) {
+ if ($insert_count == C\BATCH_SQL_INSERT_NUM) {
$insert_sql = $db->insertIgnore($insert_sql);
$db->execute($insert_sql);
$insert_count = 0;
@@ -654,7 +649,7 @@ class RecommendationJob extends MediaJob
$comma = ",";
$insert_count++;
$total_insert++;
- if ($insert_count == self::BATCH_SQL_INSERT_NUM) {
+ if ($insert_count == C\BATCH_SQL_INSERT_NUM) {
$delete_sql .= ")";
$db->execute($delete_sql, [C\GROUP_RECOMMENDATION]);
$insert_sql = $db->insertIgnore($insert_sql);
@@ -789,7 +784,7 @@ class RecommendationJob extends MediaJob
$comma = ",";
$insert_count++;
$total_insert++;
- if ($insert_count == self::BATCH_SQL_INSERT_NUM) {
+ if ($insert_count == C\BATCH_SQL_INSERT_NUM) {
$insert_sql = $db->insertIgnore($insert_sql);
$db->execute($insert_sql);
$insert_count = 0;
@@ -1130,7 +1125,7 @@ class RecommendationJob extends MediaJob
$comma = ",";
$insert_count++;
$total_insert++;
- if ($insert_count == self::BATCH_SQL_INSERT_NUM) {
+ if ($insert_count == C\BATCH_SQL_INSERT_NUM) {
$insert_sql = $db->insertIgnore($insert_sql);
$db->execute($insert_sql);
$insert_count = 0;
@@ -1251,7 +1246,7 @@ class RecommendationJob extends MediaJob
$comma = ",";
$insert_count++;
$total_insert++;
- if ($insert_count == self::BATCH_SQL_INSERT_NUM) {
+ if ($insert_count == C\BATCH_SQL_INSERT_NUM) {
$insert_sql = $db->insertIgnore($insert_sql);
$db->execute($insert_sql);
$insert_count = 0;
@@ -1342,7 +1337,7 @@ class RecommendationJob extends MediaJob
$comma = ",";
$insert_count++;
$total_insert++;
- if ($insert_count == self::BATCH_SQL_INSERT_NUM) {
+ if ($insert_count == C\BATCH_SQL_INSERT_NUM) {
$delete_sql .= ")";
$db->execute($delete_sql, [$item_type]);
$insert_sql = $db->insertIgnore($insert_sql);